Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.14.x] Fix trailing slash in Taint templating. #1649

Merged
merged 1 commit into from
Jun 27, 2019
Merged

[v0.14.x] Fix trailing slash in Taint templating. #1649

merged 1 commit into from
Jun 27, 2019

Conversation

dominicgunn
Copy link
Contributor

@dominicgunn dominicgunn commented Jun 27, 2019

Changes

  • Moving the - to the left curl braces ensures we get the formatting we want from the formatting by removing a linebreak.

Resolves #1647

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2019
@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2019
@davidmccormick davidmccormick added this to the v0.14.0-rc.3 milestone Jun 27, 2019
@dominicgunn dominicgunn merged commit 32089a0 into kubernetes-retired:v0.14.x Jun 27, 2019
@dominicgunn dominicgunn deleted the v0.14.x-improper-taint-format branch June 27, 2019 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants