Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

v0.13.x: fixes for rendering plugin systemd units #1674

Merged

Conversation

davidmccormick
Copy link
Contributor

Changed Machine.SystemdUnits to inline rather than needing contents->content.

Fixed issue rendering systemd unit templates.
Fixed issue when RemoteFileSpec contains Template and not content.
Refactored extras.go to clean up repetitive code.

…content.

Fixed issue rendering systemd unit templates.
Fixed issue when RemoteFileSpec contains Template and not content.
Refactored extras.go to clean up repeative code.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from danielfm and mumoshu July 9, 2019 14:30
@davidmccormick davidmccormick changed the title Plugin system fixes around rendering systemd units v0.13.x: Plugin system fixes around rendering systemd units Jul 9, 2019
@davidmccormick davidmccormick added this to the v0.13.0-rc.3 milestone Jul 9, 2019
@davidmccormick davidmccormick changed the title v0.13.x: Plugin system fixes around rendering systemd units v0.13.x: fixes for rendering plugin systemd units Jul 9, 2019
@codecov-io
Copy link

Codecov Report

Merging #1674 into v0.13.x will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.13.x    #1674   +/-   ##
========================================
  Coverage    25.41%   25.41%           
========================================
  Files           98       98           
  Lines         5064     5064           
========================================
  Hits          1287     1287           
  Misses        3634     3634           
  Partials       143      143
Impacted Files Coverage Δ
pkg/api/plugin.go 0% <ø> (ø) ⬆️
pkg/model/stack_new.go 33.86% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d440d...c0a0519. Read the comment docs.

@tyrannasaurusbanks
Copy link
Contributor

/lgtm & fixes the issues I was facing on my plugin migration

@omar-nahhas
Copy link
Contributor

omar-nahhas commented Jul 11, 2019

Thank you very much @davidmccormick, I have also tested it and the rendering works fine, would it be possible to extend the current tests on test/integration package to test the rendering of systemd units?

@davidmccormick davidmccormick merged commit f073d3d into kubernetes-retired:v0.13.x Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants