Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

v0.12.x: Change kiam-server 443 port name #1692

Conversation

cebernardi
Copy link
Contributor

kiam-server port name changed from commit uswitch/kiam@ceb88e1
This PR is to reflect this change in the template

kiam-server port name changed from commit uswitch/kiam@ceb88e1
This PR is to reflect this change in the template
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign redbaron
You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2019
@cebernardi
Copy link
Contributor Author

/assign @redbaron

@cebernardi
Copy link
Contributor Author

/assign @dominicgunn

@dominicgunn
Copy link
Contributor

Verified this fixes the issue. Thank you @cebernardi.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2019
@dominicgunn dominicgunn removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2019
@dominicgunn
Copy link
Contributor

I'm actually going to verify the kiam changes in these branches before merging, as the kiam version here is pretty old.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2019
@davidmccormick davidmccormick changed the title Change kiam-server 443 port name v0.12.x: Change kiam-server 443 port name Aug 5, 2019
@davidmccormick davidmccormick added this to the v0.12.5 milestone Aug 5, 2019
@dominicgunn
Copy link
Contributor

So I'm going to close this, as this branch still uses an older version of kiam where grpc is correct.

Thanks for the contribution for v0.13.x and v0.14.x.

@dominicgunn dominicgunn closed this Aug 6, 2019
@dominicgunn
Copy link
Contributor

Actually, re-opening, this is probably fine.

@dominicgunn dominicgunn reopened this Aug 6, 2019
@cebernardi
Copy link
Contributor Author

thanks @dominicgunn ,
please don't crush my hopes to get this problem solved on 1.12.x branch 🤣

@davidmccormick
Copy link
Contributor

This is needed (because of the way that Istio works) so lets merge this. ;)

@codecov-io
Copy link

Codecov Report

Merging #1692 into v0.12.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.12.x    #1692   +/-   ##
========================================
  Coverage    38.17%   38.17%           
========================================
  Files           75       75           
  Lines         4657     4657           
========================================
  Hits          1778     1778           
  Misses        2633     2633           
  Partials       246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7bab2...1ab53bb. Read the comment docs.

@davidmccormick davidmccormick merged commit 1556cc0 into kubernetes-retired:v0.12.x Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants