Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Allow extra Coredns configuration #1695

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Allow extra Coredns configuration #1695

merged 1 commit into from
Aug 16, 2019

Conversation

jorge07
Copy link
Contributor

@jorge07 jorge07 commented Aug 5, 2019

When touching the coredns configmap a cluster upgrade will overwrite the changes. This PR introduces a way to configure the changes inside the cluster config so no need to touch manually the config.

It will be ignored when other provider is specified

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign redbaron
You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2019
@jorge07
Copy link
Contributor Author

jorge07 commented Aug 5, 2019

Is this is accepted I'll need to port this to +0.1X versions

When touching the coredns configmap a cluster upgrade will overwrite the changes. This PR introduces a way to configure the changes inside the cluster config so no need to touch manually the config
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #1695 into v0.12.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.12.x    #1695      +/-   ##
===========================================
+ Coverage    38.17%   38.19%   +0.01%     
===========================================
  Files           75       75              
  Lines         4657     4658       +1     
===========================================
+ Hits          1778     1779       +1     
  Misses        2633     2633              
  Partials       246      246
Impacted Files Coverage Δ
core/controlplane/config/config.go 63.28% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7bab2...e62bd1a. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.12.5 milestone Aug 16, 2019
@davidmccormick davidmccormick merged commit 3be6c1a into kubernetes-retired:v0.12.x Aug 16, 2019
@davidmccormick
Copy link
Contributor

Thanks very much for this contribution - could you also PR this for master, 13.x and 14.x branches?

@jorge07
Copy link
Contributor Author

jorge07 commented Aug 16, 2019

Sure, will do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants