Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

update ci golang version to 1.12.x #1706

Closed
wants to merge 5 commits into from
Closed

update ci golang version to 1.12.x #1706

wants to merge 5 commits into from

Conversation

davidmccormick
Copy link
Contributor

CI should use the same golang which I build the binaries with.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2019
@chenrui333
Copy link
Contributor

Just saw this, I went ahead to bump the version to 1.13.x in #1820

@davidmccormick
Copy link
Contributor Author

This didn't work and is no longer needed

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

@davidmccormick: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dominicgunn dominicgunn Awaiting requested review from dominicgunn

@redbaron redbaron Awaiting requested review from redbaron

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmccormick @k8s-ci-robot @chenrui333