Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

move Kiam to a plugin #1726

Merged
merged 4 commits into from
Sep 10, 2019

Conversation

davidmccormick
Copy link
Contributor

Create a new kiam plugin
Remove Experimental Kiam Support Code
Fix/Allow plugins to create ca's and use them to sign other certs. Note, the CA must be created first.
Improve logging around plugin extensions.

Remove Experimental Kiam Support Code

Allow plugins to create ca's and use them to sign other certs.  Note, the CA must be created first.

Improve logging around plugin extensions.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2019
@davidmccormick davidmccormick added this to the v0.15.0 milestone Sep 9, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@eeb3f4e). Click here to learn what that means.
The diff coverage is 12.32%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1726   +/-   ##
=========================================
  Coverage          ?   25.19%           
=========================================
  Files             ?       98           
  Lines             ?     5017           
  Branches          ?        0           
=========================================
  Hits              ?     1264           
  Misses            ?     3611           
  Partials          ?      142
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø)
pkg/api/cluster.go 0% <ø> (ø)
pki/x509.go 20.58% <ø> (ø)
credential/pki.go 0% <0%> (ø)
pki/keypair.go 0% <0%> (ø)
pkg/api/keypair_spec.go 0% <0%> (ø)
credential/generator.go 0% <0%> (ø)
pki/pki.go 0% <0%> (ø)
pkg/model/credentials.go 60.6% <50%> (ø)
credential/encrypted_assets.go 57.33% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb3f4e...e50d24c. Read the comment docs.

Copy link
Contributor

@dominicgunn dominicgunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick comment about commiting go.mod and go.sum whilst we still have /vendors

go.mod Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
builtin/files/plugins/kiam/plugin.yaml Show resolved Hide resolved
Copy link
Contributor

@dominicgunn dominicgunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2019
@davidmccormick davidmccormick merged commit 90c55fb into kubernetes-retired:master Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants