-
Notifications
You must be signed in to change notification settings - Fork 294
move Kiam to a plugin #1726
move Kiam to a plugin #1726
Conversation
Remove Experimental Kiam Support Code Allow plugins to create ca's and use them to sign other certs. Note, the CA must be created first. Improve logging around plugin extensions.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1726 +/- ##
=========================================
Coverage ? 25.19%
=========================================
Files ? 98
Lines ? 5017
Branches ? 0
=========================================
Hits ? 1264
Misses ? 3611
Partials ? 142
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick comment about commiting go.mod
and go.sum
whilst we still have /vendors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
/lgtm |
Create a new kiam plugin
Remove Experimental Kiam Support Code
Fix/Allow plugins to create ca's and use them to sign other certs. Note, the CA must be created first.
Improve logging around plugin extensions.