Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.13.x] Allow CoreDNS resources to be configured #1728

Merged
merged 3 commits into from
Sep 11, 2019
Merged

[v0.13.x] Allow CoreDNS resources to be configured #1728

merged 3 commits into from
Sep 11, 2019

Conversation

dominicgunn
Copy link
Contributor

Changes

  • Allows CoreDNS resources to be configured through cluster.yaml.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dominicgunn dominicgunn added this to the v0.13.1 milestone Sep 10, 2019
@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #1728 into v0.13.x will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.13.x    #1728      +/-   ##
===========================================
- Coverage    25.32%   25.28%   -0.05%     
===========================================
  Files           98       98              
  Lines         5077     5087      +10     
===========================================
  Hits          1286     1286              
- Misses        3649     3659      +10     
  Partials       142      142
Impacted Files Coverage Δ
pkg/api/types.go 0% <ø> (ø) ⬆️
pkg/api/cluster.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad91a1b...c1bbb2f. Read the comment docs.

@davidmccormick davidmccormick modified the milestones: v0.13.1, v0.13.0, v0.13.2 Sep 10, 2019
@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2019
@davidmccormick davidmccormick merged commit e679723 into kubernetes-retired:v0.13.x Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants