This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
v0.14.x: Remove the control-plane stacks dependence on cross stack references #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… this prevents us from ever removing or changing these values. The best practice way is to pass variables as parameters between nested stacks (via the root stack). We have to remove the dependencies before we can remove the exports, so they are still exported from the etcd stack alongside our new parameters which are used in the updated control-plane stack.
davidmccormick
force-pushed
the
remove-stack-exporting
branch
from
3006c09 to
f53f2a8
Compare
davidmccormick
changed the title
Codecov Report
@@ Coverage Diff @@
## v0.14.x #1755 +/- ##
===========================================
- Coverage 25.27% 24.93% -0.35%
===========================================
Files 98 98
Lines 5088 5078 -10
===========================================
- Hits 1286 1266 -20
- Misses 3660 3673 +13
+ Partials 142 139 -3
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… this prevents us from ever removing or changing these values. The best practice is to pass variables as parameters between nested stacks (via the root stack) but we currently pass knowledge of the etcd FQDNs via CF cross-stack references. This prevents us from removing or changing their values.
This PR breaks the cross-stack reference and passes the FQDN as a parameter instead, and allows us to change the FQDNs in the future (e.g. to spin up new etcd clusters in etcd major version upgrades)