Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Kube2iam resources adjustment #1767

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Kube2iam resources adjustment #1767

merged 1 commit into from
Nov 18, 2019

Conversation

jorge07
Copy link
Contributor

@jorge07 jorge07 commented Oct 24, 2019

For cluster of +50 nodes kube2iam is throttling all the time with current limits. This one add some more margin and also remove the cpu limits what cause a performance issue

For cluster of +50 nodes kube2iam is throttling all the time with current limits. This one add some more margin and also remove the cpu limits what cause a performance issue
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign redbaron
You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #1767 into v0.12.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.12.x    #1767   +/-   ##
========================================
  Coverage    38.19%   38.19%           
========================================
  Files           75       75           
  Lines         4658     4658           
========================================
  Hits          1779     1779           
  Misses        2633     2633           
  Partials       246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be6c1a...7890f7e. Read the comment docs.

@davidmccormick
Copy link
Contributor

Interestingly, we ended up adjusting the limits for the v0.15.x kube2iam plugin.
limits:
memory: 128Mi
requests:
cpu: 100m
memory: 64Mi
So this brings v0.12.x in line with the same settings. One thing would you please consider also PRing to both v0.13.x and v0.14.x branches too please? Otherwise, when you upgrade the resource setting is likely to be reset back to the old one...

@davidmccormick davidmccormick added this to the v0.12.6 milestone Nov 18, 2019
@davidmccormick davidmccormick merged commit 48caf0c into kubernetes-retired:v0.12.x Nov 18, 2019
@davidmccormick
Copy link
Contributor

Many thanks for contributing this change! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants