This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
v0.14.x: CoreDNS prometheus metric annotations exposed at pod level #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These annotations would previously never be rendered because they were added under the kube-dns section (rather than CoreDNS's). Additionally, the annotations are now added to the Pods themselves rather than the Deployment.
kfr2
force-pushed
the
coredns-prometheus-metrics-14x
branch
from
e6a143b to
917d490
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
kfr2
changed the title
Codecov Report
@@ Coverage Diff @@
## v0.14.x #1771 +/- ##
========================================
Coverage 24.93% 24.93%
========================================
Files 98 98
Lines 5078 5078
========================================
Hits 1266 1266
Misses 3673 3673
Partials 139 139Continue to review full report at Codecov.
|
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These annotations would previously never be rendered because they
were added under the kube-dns section (rather than CoreDNS's).
Additionally, the annotations are now added to the Pods themselves
rather than the Deployment.
Fixes #1768