Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Add flag to cmds to use AWS profile #1790

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

javipolo
Copy link
Contributor

Add a new flag to command line utilities to allow to choose a AWS profile from the aws credentials file

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mumoshu
You can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #1790 into v0.14.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.14.x    #1790   +/-   ##
========================================
  Coverage    24.93%   24.93%           
========================================
  Files           98       98           
  Lines         5078     5078           
========================================
  Hits          1266     1266           
  Misses        3673     3673           
  Partials       139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1abe5b...6d91a65. Read the comment docs.

Copy link
Contributor

@davidmccormick davidmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2019
@davidmccormick davidmccormick merged commit 28dc23b into kubernetes-retired:v0.14.x Nov 29, 2019
@davidmccormick davidmccormick added this to the v0.14.3 milestone Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants