Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Add proper indentation to extra CoreDNS config #1813

Merged
merged 1 commit into from
Jan 4, 2020

Conversation

javipolo
Copy link
Contributor

@javipolo javipolo commented Jan 3, 2020

When using more than one line of extra config, the indentation was not right and generated YAML was not valid

This should fix this issue

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign c-knowles
You can assign the PR to them by writing /assign @c-knowles in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #1813 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1813   +/-   ##
======================================
  Coverage    24.6%   24.6%           
======================================
  Files          98      98           
  Lines        5069    5069           
======================================
  Hits         1247    1247           
  Misses       3682    3682           
  Partials      140     140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f0b254...74aae52. Read the comment docs.

@davidmccormick davidmccormick added this to the v0.16.0 milestone Jan 4, 2020
@davidmccormick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2020
@davidmccormick davidmccormick merged commit 9e197df into kubernetes-retired:master Jan 4, 2020
@davidmccormick
Copy link
Contributor

Many thanks for this fix! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants