Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.16.0] Fix ApiServerAggregatorKeyPath unnamed flag #1850

Merged
merged 1 commit into from
May 14, 2020
Merged

[v0.16.0] Fix ApiServerAggregatorKeyPath unnamed flag #1850

merged 1 commit into from
May 14, 2020

Conversation

jorge07
Copy link
Contributor

@jorge07 jorge07 commented May 12, 2020

Fixes #1849

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #1850 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1850   +/-   ##
=======================================
  Coverage   24.40%   24.40%           
=======================================
  Files          98       98           
  Lines        5117     5117           
=======================================
  Hits         1249     1249           
  Misses       3728     3728           
  Partials      140      140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 198de8a...20855ed. Read the comment docs.

@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020
@dominicgunn dominicgunn merged commit bd0633d into kubernetes-retired:master May 14, 2020
@dominicgunn dominicgunn changed the title Fix ApiServerAggregatorKeyPath unnamed flag [v0.14.5] Fix ApiServerAggregatorKeyPath unnamed flag May 18, 2020
@dominicgunn dominicgunn changed the title [v0.14.5] Fix ApiServerAggregatorKeyPath unnamed flag [v0.16.0] Fix ApiServerAggregatorKeyPath unnamed flag May 18, 2020
@dominicgunn dominicgunn added this to the v0.16.0 milestone May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants