Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.16.0] bugfix: flannel SubnetLen expects an int not an string #1853

Merged

Conversation

Fsero
Copy link
Contributor

@Fsero Fsero commented May 18, 2020

I was creating a cluster from latest and it seems that flannel expects an int

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2020
@Fsero Fsero force-pushed the make_flannel_leases_configurable branch from 2a5622b to c54abd5 Compare May 18, 2020 12:10
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 18, 2020
@Fsero
Copy link
Contributor Author

Fsero commented May 18, 2020

/assign @dominicgunn

@dominicgunn
Copy link
Contributor

Thanks for doing this, I haven't gotten around to testing the v0.16.x branch yet. Appreciate the due diligence.

@dominicgunn dominicgunn merged commit bdc0325 into kubernetes-retired:master May 18, 2020
@dominicgunn dominicgunn added this to the v0.16.0 milestone May 18, 2020
@dominicgunn dominicgunn changed the title bugfix: flannel SubnetLen expects an int not an string [v0.16.0] bugfix: flannel SubnetLen expects an int not an string May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants