[v0.16.0] Creating a switch to disable ICMP Ping instead of the default allow 0.0.0/0

[HarryStericker]

Currently kube-aws includes a rule in its security group to allow ping from all traffic (0.0.0.0/0). Unless this is necessary for a reason I have not foreseen, it is an inherent security risk, violates CIS compliance, and is probably superfluous if SG's are managed appropriately.

Therefore, I have created a switch in cluster.yaml to allow removal of this rule. I have left it enabled by default but am conscious that anyone upgrading needs to ensure this is in their cluster.yaml, so am happy to adjust the logic so that there's no impact unless you explicitly ask for it to be disabled.

I don't think I've missed any other spots where this rule is used.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign redbaron
You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[HarryStericker]

Hey @dominicgunn, can i get a few pointers when you have time. Not sure what needs modifying to fix the build errors.

[dominicgunn]

Left a comment for you @HarryStericker

[dominicgunn]

I think this might be your issue. Now that this is optional ({{ if .... }}) the block above is going to leave a trailing , if this is disabled, like this.

....
    "ToPort": 22
  },
]

We can't have that trailing , if openICMP is disabled.

This will also need changes to the go code, so we can add OpenICMP as a struct. Do a search for cloudFormationStreaming.

[codecov-commenter]

Codecov Report

Merging #1854 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1854   +/-   ##
=======================================
  Coverage   24.40%   24.40%           
=======================================
  Files          98       98           
  Lines        5117     5117           
=======================================
  Hits         1249     1249           
  Misses       3728     3728           
  Partials      140      140           

Impacted Files	Coverage Δ
pkg/api/cluster.go	0.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0633d...4aad063. Read the comment docs.

[dominicgunn]

/lgtm