This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Node Pool Nested Stack Name #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 69.11% (diff: 66.66%)@@ master #187 diff @@
==========================================
Files 4 4
Lines 1130 1130
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 781 781
Misses 261 261
Partials 88 88
|
mumoshu
reviewed
Jan 3, 2017
| @@ -693,7 +693,7 @@ type Config struct { | |||
|
|
|||
| // CloudFormation stack name which is unique in an AWS account. | |||
| // This is intended to be used to reference stack name from cloud-config as the target of awscli or cfn-bootstrap-tools commands e.g. `cfn-init` and `cfn-signal` | |||
| func (c Config) StackName() string { | |||
| func (c Cluster) StackName() string { | |||
| return c.ClusterName | |||
There was a problem hiding this comment.
nit: Any specific reason to move this method from Config to Cluster? (I guess for now there's no specific reason/it doesn't relate to the main purpose of this PR but you just thought it might be better to do so?
There was a problem hiding this comment.
Only that StackName was not available in the context of Cluster functions.
There was a problem hiding this comment.
Got it! I somehow missed from where the ClusterName field is coming.
|
E2E passed. LGTM 👍 |
|
@mumoshu do we want to also update the name tags of subresources? |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…-names Node Pool Nested Stack Name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nest node pool stack name by cluster name to avoid conflict when running multiple clusters.
e.g.