Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.14.x] Add proper indentation to additional zone CoreDNS config #1877

Conversation

kfr2
Copy link
Contributor

@kfr2 kfr2 commented Jul 1, 2020

This PR adds proper indentation to the additional zone CoreDNS change introduced with #1875.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from cknowles and danielfm July 1, 2020 14:00
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2020
@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@kfr2 kfr2 force-pushed the indent-KubeDns.AdditionalZoneCoreDNSConfig branch from 80bd516 to 6d5ccb2 Compare July 2, 2020 11:58
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@dominicgunn dominicgunn merged commit ae2f65a into kubernetes-retired:v0.14.x Jul 2, 2020
@kfr2 kfr2 deleted the indent-KubeDns.AdditionalZoneCoreDNSConfig branch July 2, 2020 14:40
@dominicgunn dominicgunn changed the title Add proper indentation to additional zone CoreDNS config [v0.14.x] Add proper indentation to additional zone CoreDNS config Jul 3, 2020
@dominicgunn dominicgunn added this to the v0.14.6 milestone Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants