Remove "Restart=on-failure" from kube-node-drainer.service

[camilb]

Systemd only allows "Restart=no" for "Type=oneshot" services.

[codecov-io]

Current coverage is 56.90% (diff: 100%)

Merging #41 into master will not change coverage

@@             master        #41   diff @@
==========================================
  Files             4          4          
  Lines           949        949          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            540        540          
  Misses          329        329          
  Partials         80         80          

Powered by Codecov. Last update 6255751...020a9ce

[pieterlange]

While we're at it: is the double $$ intentional here? Some weird double escaping? I think just $(hostname) would work?

[pieterlange]

Thanks! Restart= indeed makes no sense on oneshot services.

[camilb]

Apart from this, maybe it's a good idea to replace ExecStart: /bin/true with:

        ExecStart=/bin/sh -c '/usr/bin/docker run --rm -v /etc/kubernetes:/etc/kubernetes {{.HyperkubeImageRepo}}:{{.K8sVer}} \
      /hyperkube kubectl \
      --server=https://{{.ExternalDNSName}}:443 \
      --kubeconfig=/etc/kubernetes/worker-kubeconfig.yaml \
      uncordon $(hostname)'

If the node reboots, it will be marked automatically as schedulable.

[mumoshu]

@camilb Ah, I know i'm to blame! Thanks for the fix 🙇

[mumoshu]

@pieterlange Yes, $$ is intentional. I remember that I referred to

To pass a literal dollar sign, use "$$".
https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines

Basically I tried my best to make sure $$(hostname) to get expanded at runtime. I guess if $(hostname) isn't recognized as a systemd variable, it also work as we might expect 👍