Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Cherry-Pick #306 from Volcano #875

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

asifdxtreme
Copy link
Contributor

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 9, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @asifdxtreme. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2019
@asifdxtreme
Copy link
Contributor Author

I Signed it

@hex108
Copy link
Contributor

hex108 commented Jul 9, 2019

william-wang needs CLA

It might be the problem. cc @william-wang

@william-wang
Copy link

I just Signed the CLA.

@k82cn
Copy link
Contributor

k82cn commented Jul 9, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2019
@asifdxtreme
Copy link
Contributor Author

/check-cla

@asifdxtreme asifdxtreme reopened this Jul 11, 2019
@asifdxtreme
Copy link
Contributor Author

I just Signed the CLA.

@william-wang Can you please try to signin again with exactly same username as github

@william-wang
Copy link

@william-wang Can you please try to signin again with exactly same username as github
I just signed again.

@k82cn
Copy link
Contributor

k82cn commented Jul 12, 2019

it is better to get this one merged this week!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 15, 2019
@asifdxtreme
Copy link
Contributor Author

@k82cn Does this PR needs to be a part of v0.5 release?

@asifdxtreme
Copy link
Contributor Author

/assign @k82cn

@k82cn
Copy link
Contributor

k82cn commented Jul 15, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asifdxtreme, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit b9bf82a into kubernetes-retired:master Jul 15, 2019
@k82cn
Copy link
Contributor

k82cn commented Jul 16, 2019

please also cherry-pick to 0.5 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants