Update linters and gofmt script #1274
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
jimmidyson
changed the title
|
/cc @hectorj2f |
jimmidyson
force-pushed
the
jimmi/fix-update-gofmt-script
branch
from
e60fffb to
751997b
Compare
|
@irfanurrehman @RainbowMango do you have any comment regarding this change ? Otherwise I'd say, we can merge it. |
|
Just quickly went through the PR. LGTM. Thanks. Would you like to take an eye on it? @irfanurrehman |
|
I can imagine it becomes harder to make the robot happy:) Hope people/contributor won't get crazy with so many linters :) |
|
I'd wait for @irfanurrehman before giving it the |
|
@RainbowMango the majority of these linters were already applied by virtue of being on by default. This pr just explicitly specifies then to reduce chance of surprise on upgrade of golangci-lint. |
|
Thanks for doing this @jimmidyson. |
jimmidyson
force-pushed
the
jimmi/fix-update-gofmt-script
branch
from
751997b to
9aaf65a
Compare
|
/lgtm |
What this PR does / why we need it:
Update golangci-lint configuration to explicitly list all enabled linters and add a few more to the existing set. The original change was driven by a desire to remove gofmt scripts and relying on golangci-lint in combination with goimports to provide formatting and validation.
Second commit fixes all lint failures.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Sorry for PRs like this but as we're working on the codebase more, I would like to ensure we have as good tooling for keeping a consistent codebase as much as possible.