This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Introduce cluster config malformed condition to KubeFedCluster #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
zqzten
changed the title
zqzten
force-pushed
the
kubefedcluster_condition
branch
2 times, most recently
from
0fbc077 to
fb3e51e
Compare
hectorj2f
reviewed
Nov 12, 2021
zqzten
force-pushed
the
kubefedcluster_condition
branch
from
fb3e51e to
086ef8d
Compare
recoverable when a KubeFedCluster's malformed Secret get fixed
|
/assign @hectorj2f |
|
friendly ping @hectorj2f for approval or further opinion |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irfanurrehman, zqzten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently when a ready KubeFedCluster's config become malformed (e.g. by deleting its Secret or some other necessary fields), there's no way to change its status to not ready. This can lead to some misbehavior of KubeFed controller and can also confuse maintainers.
This PR introduce a
ConfigMalformedcondition to KubeFedCluster to correctly reflect the unready status of a KubeFedCluster with malformed configuration.It also mark
ClientRetrievalFailedas a recoverable error since it's recoverable when some KubeFedCluster's malformed Secret get fixed.Which issue(s) this PR fixes:
Fixes #1475