Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Switch from glog to klog #857

Merged
merged 4 commits into from
May 9, 2019
Merged

Conversation

font
Copy link
Contributor

@font font commented May 8, 2019

#695 is WIP, but this switch to use klog is needed in order to enable webhook dependencies in a follow-up PR.

Posting on behalf of @pmorie who did the work.

Fixes #694

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2019
@k8s-ci-robot k8s-ci-robot requested a review from gyliu513 May 8, 2019 02:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: font

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 8, 2019
@marun
Copy link
Contributor

marun commented May 8, 2019

@font I guess neither you nor @pmorie noticed that @poothia had already started work on this in #695?

@poothia fyi, you can close yours.

Copy link
Contributor

@xunpan xunpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall it LGTM

"github.com/kubernetes-sigs/federation-v2/pkg/controller/util"
"k8s.io/klog"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s.io is a third party package. It should be better on top of federation package as indepedent section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This is a default gofmt placement since there's no space.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention we've converged on is:

import (
  <system imports (e.g. fmt)>

  <3rd party imports (e.g. glog, errors)>

  <k8s imports (e.g. klog, metav1)>

  <fedv2 imports>
 
  [<test-specific imports>]
)

@font
Copy link
Contributor Author

font commented May 8, 2019

@font I guess neither you nor @pmorie noticed that @poothia had already started work on this in #695?

@poothia fyi, you can close yours.

@marun I made a comment about it that it looks like it is WIP and hasn't been updated recently. It's not my intent to take the work from @poothia (apologies!), it was more to see it through since a follow-up PR for the webhook framework which depends on it is forthcoming.

@font
Copy link
Contributor Author

font commented May 8, 2019

@marun @xunpan I've pushed a commit that reorders things based on our converged convention. We should really document that in the development guide.

@font font mentioned this pull request May 8, 2019
3 tasks
@marun
Copy link
Contributor

marun commented May 9, 2019

Thanks @font and @pmorie!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit f8c0470 into kubernetes-retired:master May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a forked version of glog in kubernetes
6 participants