Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Add validation webhook dependencies #867

Merged
merged 2 commits into from
May 10, 2019
Merged

Add validation webhook dependencies #867

merged 2 commits into from
May 10, 2019

Conversation

font
Copy link
Contributor

@font font commented May 9, 2019

NOTE: This PR is not reviewable until #866 is merged.

This adds the webhook dependencies used by #862.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: font

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 9, 2019
@font font mentioned this pull request May 9, 2019
Merged
3 tasks
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2019
@marun
Copy link
Contributor

marun commented May 10, 2019

LGTM. That's a heck of a lot of code for a kube point release.

@shashidharatd
Copy link
Contributor

@font, it would be better if we separate the changes to Gopkg.toml to a separate commit. Also please rebase as #866 is merged now.

@font
Copy link
Contributor Author

font commented May 10, 2019

@shashidharatd Rebased and separated out Gopkg.toml as requested. PTAL.

@font font changed the title WIP: Add validation webhook dependencies Add validation webhook dependencies May 10, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2019
@marun
Copy link
Contributor

marun commented May 10, 2019

@irfanurrehman Would you please merge in @shashidharatd's absence?

@marun marun mentioned this pull request May 10, 2019
Merged
@pmorie
Copy link
Contributor

pmorie commented May 10, 2019 •
edited
Loading

/lgtm

Per our earlier discussion, we decided it was okay to merge this for expedience's sake.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit e40bf53 into kubernetes-retired:master May 10, 2019
@font font deleted the webhook-deps branch May 11, 2019 01:36
@irfanurrehman
Copy link
Contributor

/lgtm

Per our earlier discussion, we decided it was okay to merge this for expedience's sake.

Also, I think doing this is perfectly fair and the same stand could be taken for any other PR which needs quicker merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marun marun Awaiting requested review from marun

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@pmorie pmorie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@font @k8s-ci-robot @fejta-bot @marun @shashidharatd @pmorie @irfanurrehman