Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Increase memory limits and requests and update docs #1306

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

yiqigao217
Copy link
Contributor

@yiqigao217 yiqigao217 commented Dec 4, 2020

Increase memory limits to 300M and requests to 150M since we store more
info, e.g. source objects, in the forest now. About 700 namespaces with
10 propagatable objects in each namespace would use about 200M memory
from performance tests.

Add memory usage in user-guide faq docs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2020
@yiqigao217
Copy link
Contributor Author

/assign @adrianludwin

@rjbez17
Copy link

rjbez17 commented Dec 4, 2020

Do we have any docs anywhere describing how an end user would determine the recommended limit/request sizes?

@rjbez17
Copy link

rjbez17 commented Dec 4, 2020

This lgtm other than the one question about docs.

@adrianludwin
Copy link
Contributor

Discussed with @yiqigao217 - she's going to add our performance and memory testing results to the FAQ, and also increase the limits slightly as these limits are pretty tight for at least one known real usecase. We're going to go with 150MB request and 300MB limit.

Increase memory limits to 300M and requests to 150M since we store more
info, e.g. source objects, in the forest now. About 700 namespaces with
10 propagatable objects in each namespace would use about 200M memory
from performance tests.

Add memory usage in user-guide faq docs.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2020
@rjbez17
Copy link

rjbez17 commented Dec 7, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjbez17, yiqigao217

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@yiqigao217 yiqigao217 changed the title Increase memory limits and requests Increase memory limits and requests and update docs Dec 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a46538 into kubernetes-retired:master Dec 7, 2020
@adrianludwin adrianludwin added this to the hnc-v0.7 milestone Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants