Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

bump go 1.11.5 #2573

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Conversation

jberkhahn
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2019
@jberkhahn
Copy link
Contributor Author

/retest

Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably time to nuke contrib/jenkins/init_build.sh

Makefile Outdated
@@ -57,7 +57,7 @@ STAT = stat -c '%Y %n'
endif

TYPES_FILES = $(shell find pkg/apis -name types.go)
GO_VERSION ?= 1.11.3
GO_VERSION ?= 1.11.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other option here is to go back to the unanchored version "1.11" at which point docker will always be pulling the freshest "1.11"

@MHBauer
Copy link
Contributor

MHBauer commented Mar 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2019
@MHBauer
Copy link
Contributor

MHBauer commented Mar 7, 2019

/assign @jboyd01

@jboyd01
Copy link
Contributor

jboyd01 commented Mar 11, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jboyd01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit ccfb22a into kubernetes-retired:master Mar 11, 2019
viviyww pushed a commit to viviyww/service-catalog that referenced this pull request May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants