This repository has been archived by the owner on May 6, 2022. It is now read-only.
Add namespaced e2e tests #2598
Merged
Add namespaced e2e tests #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/XL
jberkhahn
force-pushed
the
e2e_namespace
branch
3 times, most recently
from
5210c5f to
72fd45c
Compare
jberkhahn
commented
Apr 8, 2019
| @@ -175,7 +175,7 @@ $(BINDIR)/%-gen: $$(shell find vendor/k8s.io/code-generator/cmd/$$*-gen vendor/k | |||
|
|
|||
| .PHONY: $(BINDIR)/e2e.test | |||
| $(BINDIR)/e2e.test: .init | |||
| $(DOCKER_CMD) go test -c -o $@ $(SC_PKG)/test/e2e | |||
| $(DOCKER_CMD) env GOOS=$(CLIENT_PLATFORM) GOARCH=$(ARCH) go test -c -o $@ $(SC_PKG)/test/e2e | |||
MHBauer
approved these changes
Apr 8, 2019
jboyd01
reviewed
Apr 9, 2019
test/util/util.go
Outdated
| genericapirequest "k8s.io/apiserver/pkg/endpoints/request" | ||
| utilfeature "k8s.io/apiserver/pkg/util/feature" | ||
| ) | ||
|
|
||
| // WaitForBrokerCondition waits for the status of the named broker to contain | ||
| // a condition whose type and status matches the supplied one. | ||
| func WaitForBrokerCondition(client v1beta1servicecatalog.ServicecatalogV1beta1Interface, name string, condition v1beta1.ServiceBrokerCondition) error { | ||
| // a condition whose type and status matches the supplied onei. Checks for a |
- change build-e2e make target to compile on host os/arch - refactor test/util helper methods to work on both cluster/ns resources
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jboyd01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
onei |
viviyww
pushed a commit
to viviyww/service-catalog
that referenced
this pull request
May 10, 2019
- change build-e2e make target to compile on host os/arch - refactor test/util helper methods to work on both cluster/ns resources
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a
Fixes #2408
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update