add default values for apiVersion to be able to use helm template

[gree-gorey]

add default values in Helm chart service-catalog for apiVersion to be able to use helm template without talking to API

This PR is a

• Feature Implementation
• Bug Fix
• Documentation

What this PR does / why we need it:
The issue described in #2592. This PR adds default values for apiVersion that currently are not set when using helm template because .Capabilities.APIVersions.Has is empty:

$ helm template --name=catalog --namespace=default . | kubectl apply --dry-run -f -
service/catalog-catalog-apiserver created (dry run)
deployment.extensions/catalog-catalog-apiserver created (dry run)
deployment.extensions/catalog-catalog-controller-manager created (dry run)
error: error validating "STDIN": error validating data: apiVersion not set; if you choose to ignore these errors, turn validation off with --validate=false

After fixing it:

$ helm template --name=catalog --namespace=default . | kubectl apply --dry-run -f -
service/catalog-catalog-apiserver created (dry run)
deployment.extensions/catalog-catalog-apiserver created (dry run)
deployment.extensions/catalog-catalog-controller-manager created (dry run)
apiservice.apiregistration.k8s.io/v1beta1.servicecatalog.k8s.io created (dry run)
secret/catalog-catalog-apiserver-cert created (dry run)
clusterrole.rbac.authorization.k8s.io/servicecatalog.k8s.io:apiserver created (dry run)
clusterrolebinding.rbac.authorization.k8s.io/servicecatalog.k8s.io:apiserver created (dry run)
clusterrolebinding.rbac.authorization.k8s.io/servicecatalog.k8s.io:apiserver-auth-delegator created (dry run)
rolebinding.rbac.authorization.k8s.io/servicecatalog.k8s.io:apiserver-authentication-reader created (dry run)
clusterrole.rbac.authorization.k8s.io/servicecatalog.k8s.io:controller-manager created (dry run)
clusterrolebinding.rbac.authorization.k8s.io/servicecatalog.k8s.io:controller-manager created (dry run)
role.rbac.authorization.k8s.io/servicecatalog.k8s.io:cluster-info-configmap created (dry run)
rolebinding.rbac.authorization.k8s.io/service-catalog-controller-manager-cluster-info created (dry run)
role.rbac.authorization.k8s.io/servicecatalog.k8s.io:leader-locking-controller-manager created (dry run)
rolebinding.rbac.authorization.k8s.io/service-catalog-controller-manager-leader-election created (dry run)
clusterrole.rbac.authorization.k8s.io/servicecatalog.k8s.io:service-catalog-readiness created (dry run)
clusterrolebinding.rbac.authorization.k8s.io/servicecatalog.k8s.io:service-catalog-readiness created (dry run)
serviceaccount/service-catalog-apiserver created (dry run)
serviceaccount/service-catalog-controller-manager created (dry run)

Which issue(s) this PR fixes

Fixes #2592

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

• New feature
  • Tests
  • Documentation
• SVCat CLI flag
• Server Flag for config
  • Chart changes
  • removing a flag by marking deprecated and hiding to avoid
    breaking the chart release and existing clients who provide a
    flag that will get an error when they try to update

[k8s-ci-robot]

Hi @gree-gorey. Thanks for your PR.

I'm waiting for a kubernetes-incubator or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MHBauer]

/ok-to-test

[jberkhahn]

/test pull-service-catalog-integration

[MHBauer]

seems okay, I worry about silent failures in the future when these are deprecated.

[jberkhahn]

/lgtm

[MHBauer]

authorization stuff is v1 since 1.12 at least, https://kubernetes.io/docs/reference/

We should support that as well.

[MHBauer]

/approve
brought it up in the april 15th service-catalog meeting.
@jberkhahn to handle some time this week

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MHBauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MHBauer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment