-
Notifications
You must be signed in to change notification settings - Fork 381
Take advertise client urls from configuration #2640
Conversation
Welcome @rafis! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @rafis. Thanks for your PR. I'm waiting for a kubernetes-incubator or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test you need to sign the CLA, though |
/test pull-service-catalog-xbuild |
2 similar comments
/test pull-service-catalog-xbuild |
/test pull-service-catalog-xbuild |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jberkhahn, rafis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-service-catalog-xbuild |
This PR is a
What this PR does / why we need it:
Possibly fixes a bug, please review.
Which issue(s) this PR fixes
Fixes #
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update