Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Update project status #2691

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Update project status #2691

merged 1 commit into from
Aug 26, 2019

Conversation

adamwalach
Copy link
Contributor

This PR is a

  • Feature Implementation
  • Bug Fix
  • Documentation

What this PR does / why we need it:

Which issue(s) this PR fixes

Related to:

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

  • New feature
    • Tests
    • Documentation
  • SVCat CLI flag
  • Server Flag for config
    • Chart changes
    • removing a flag by marking deprecated and hiding to avoid
      breaking the chart release and existing clients who provide a
      flag that will get an error when they try to update

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @adamwalach. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 22, 2019
@mszostok
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2019
@adamwalach
Copy link
Contributor Author

/test pull-build-all-images-for-arm

@adamwalach
Copy link
Contributor Author

/test pull-build-all-images-for-arm64

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2019
@adamwalach
Copy link
Contributor Author

/test pull-build-all-images-for-arm64

mszostok
mszostok reviewed Aug 22, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
docs/install.md Outdated

* Latest release: https://download.svcat.sh/cli/latest
* Latest release from v2 branch: https://download.svcat.sh/cli/latest-v2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mentioned only the release, maybe it's worth to do that for all other types, e.g. sth like that:

The snippets below install the latest version of svcat. We also publish binaries for our canary builds, and tags using the following prefixes:

docs/install.md Outdated
@@ -115,7 +109,8 @@ You should see the following output:

```console
NAME VERSION DESCRIPTION
svc-cat/catalog x,y.z service-catalog API server and controller-manag...
svc-cat-kyma/catalog 0.3.X service-catalog
Copy link
Contributor

@mszostok mszostok Aug 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format output, so columns will be aligned

svc-cat/catalog           	 0.3.X  service-catalog
svc-cat/catalog-v0.2	 0.2.X  service-catalog API server ....

@mszostok
Copy link
Contributor

/test pull-build-all-images-for-arm

@adamwalach adamwalach force-pushed the update-status branch 5 times, most recently from f83c236 to 747d7d5 Compare August 23, 2019 09:08
@adamwalach
Copy link
Contributor Author

/test pull-build-all-images-for-arm

@adamwalach
Copy link
Contributor Author

/test pull-build-all-images-for-ppc64le

1 similar comment
@adamwalach
Copy link
Contributor Author

/test pull-build-all-images-for-ppc64le

mszostok
mszostok reviewed Aug 26, 2019
View reviewed changes
docs/install.md Outdated
NAME VERSION DESCRIPTION
svc-cat/catalog x,y.z service-catalog API server and controller-manag...
NAME VERSION DESCRIPTION
svc-cat-kyma/catalog 0.3.X service-catalog
Copy link
Contributor

@mszostok mszostok Aug 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be changed to sig-sc

svc-cat/catalog      	0.2.1        	           	service-catalog API server and controller-manager helm chart
svc-cat/catalog-v0.2 	0.2.2        	           	service-catalog API server and controller-manager helm chart

@mszostok
Add information about the current project status
b030a22 
- Update install process both for master and v0.2 branch
- Add information about new CRD impl
- Add information about deprecating api-server based impl
@jberkhahn
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamwalach, jberkhahn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit bbd2669 into kubernetes-retired:master Aug 26, 2019
@mszostok mszostok mentioned this pull request Sep 27, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mszostok mszostok mszostok left review comments

@MHBauer MHBauer Awaiting requested review from MHBauer

Assignees

@jberkhahn jberkhahn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamwalach @k8s-ci-robot @mszostok @jberkhahn