This repository has been archived by the owner on May 6, 2022. It is now read-only.
Add CRD waiter for migration job and webhook server #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mszostok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
mszostok
force-pushed
the
fix-upgrade-job
branch
from
3b97596
to
68800b2
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
mszostok
force-pushed
the
fix-upgrade-job
branch
2 times, most recently
from
5ca08e0
to
13da337
Compare
It may take some time before Catalog CRDs registration shows up in main API Server. Because of that the CRD waiter is executed for each binary. Additionally, we added retries when restoring Service Catalog resources during the migration process.
mszostok
force-pushed
the
fix-upgrade-job
branch
from
13da337
to
c926838
Compare
|
@jberkhahn PTAL /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
jberkhahn
reviewed
Oct 3, 2019
| // RetryOnError allows the caller to retry fn in case the error returned by fn is retriable | ||
| // according to the provided function. backoff defines the maximum retries and the wait | ||
| // interval between two retries. | ||
| func RetryOnError(backoff wait.Backoff, fn func() error) error { |
There was a problem hiding this comment.
I could have sworn we had a util function for this somewhere, but I can't seem to find it
There was a problem hiding this comment.
tomorrow, I will double recheck that. Basically, this func was inspired by the client-go retry policy but maybe it is already somewhere in our code.
btw. thanks for the review:)
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It may take some time before Catalog CRDs registration shows up in main API Server.
Because of that the CRD waiter is executed for each binary. Additionally, we added
retries when restoring Service Catalog resources during the migration process.
See discussion in this thread for more info: https://kubernetes.slack.com/archives/C232SF3TK/p1570107013007500
Related issue: