Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Improve travis build - skip redundant jobs #2731

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Improve travis build - skip redundant jobs #2731

merged 3 commits into from
Oct 17, 2019

Conversation

adamwalach
Copy link
Contributor

This PR is a

  • Feature Implementation
  • Bug Fix
  • Documentation

What this PR does / why we need it:
It fixes b

Which issue(s) this PR fixes
Fixes kyma-project/kyma#6007

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

  • New feature
    • Tests
    • Documentation
  • SVCat CLI flag
  • Server Flag for config
    • Chart changes
    • removing a flag by marking deprecated and hiding to avoid
      breaking the chart release and existing clients who provide a
      flag that will get an error when they try to update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @adamwalach. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2019
@adamwalach
Copy link
Contributor Author

Release process is now controlled by DEPLOY_TYPE variable set in .travis file.
In case of commit to master "SC release *" jobs are triggered but they do not perform any action:
Screen Shot 2019-10-16 at 11 56 37
In the logs you can see:
Screen Shot 2019-10-16 at 12 20 47
Opposite situation(SC-master is skipped) occurs when new release is created:
Screen Shot 2019-10-16 at 12 36 05

@mszostok
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2019
@mszostok
Copy link
Contributor

/test pull-service-catalog-test-integration

@mszostok
Copy link
Contributor

nice, btw. name per stage improved readability, good idea 👍

@mszostok
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@mszostok
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamwalach, mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit dda1fc0 into kubernetes-retired:master Oct 17, 2019
@mszostok mszostok deleted the fix/sc-travis-release branch October 17, 2019 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the release pipeline in the Service Catalog repo
3 participants