Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

fix pb when use securityContext and add opportunity to add storageclass #2818

Merged
merged 5 commits into from
Jun 10, 2020

Conversation

obeyler
Copy link
Contributor

@obeyler obeyler commented Jun 9, 2020

This PR is a

  • Feature Implementation
  • Bug Fix
  • Documentation

What this PR does / why we need it:
-Feature: add the opportunity to use a specific storageClass, it's mandatory when no default storageclass is defined inside a K8S.
In our casen we have multiple StorageClass in our cluster, so as each one has its strengths, we don't put a particular one as a default to force the user to ask himself the question of which one to choose and why he chose it.

It also fix a pb on securitycontext

Which issue(s) this PR fixes
Fixes #2819
-Bug fix: If a securityContext is set the process is not able to create directory

I0609 12:50:10.145130       1 controller_manager.go:135] Using inClusterConfig to talk to service catalog API server -- make sure your API server is registered with the aggregator
Error: failed to establish SecureServingOptions mkdir /var/run/kubernetes-service-catalog: permission denied

To solve it I create an emptyDir volume
The securitycontext is also add for job and webhook

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

  • New feature
    • Tests
    • Documentation
  • SVCat CLI flag
  • Server Flag for config
    • Chart changes
    • removing a flag by marking deprecated and hiding to avoid
      breaking the chart release and existing clients who provide a
      flag that will get an error when they try to update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @obeyler. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from jberkhahn and MHBauer June 9, 2020 13:38
@mszostok
Copy link
Contributor

mszostok commented Jun 9, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2020
@obeyler
Copy link
Contributor Author

obeyler commented Jun 9, 2020

/retest

olivier beyler added 3 commits June 9, 2020 18:31
@obeyler
Copy link
Contributor Author

obeyler commented Jun 9, 2020

@jberkhahn @MHBauer I don't see why this two last test failed. Do you think that it could be something that occured without my change ?

@jberkhahn
Copy link
Contributor

given that you're just plumbing stuff through the Helm charts I find it very unlikely the image build is failing because of that. It looks like it's timing out. Same of the integration tests, which also look like they're timing out. Prow might just be overloaded right now.

@obeyler
Copy link
Contributor Author

obeyler commented Jun 10, 2020

/retest

@obeyler
Copy link
Contributor Author

obeyler commented Jun 10, 2020

hi @jberkhahn @MHBauer just waiting for your /lgtm label now :-)

@jberkhahn
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn, obeyler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5068f67 into kubernetes-retired:master Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a securityContext is set the container crash
4 participants