-
Notifications
You must be signed in to change notification settings - Fork 382
fix pb when use securityContext and add opportunity to add storageclass #2818
fix pb when use securityContext and add opportunity to add storageclass #2818
Conversation
Hi @obeyler. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
@jberkhahn @MHBauer I don't see why this two last test failed. Do you think that it could be something that occured without my change ? |
given that you're just plumbing stuff through the Helm charts I find it very unlikely the image build is failing because of that. It looks like it's timing out. Same of the integration tests, which also look like they're timing out. Prow might just be overloaded right now. |
/retest |
hi @jberkhahn @MHBauer just waiting for your /lgtm label now :-) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jberkhahn, obeyler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is a
What this PR does / why we need it:
-Feature: add the opportunity to use a specific storageClass, it's mandatory when no default storageclass is defined inside a K8S.
In our casen we have multiple StorageClass in our cluster, so as each one has its strengths, we don't put a particular one as a default to force the user to ask himself the question of which one to choose and why he chose it.
It also fix a pb on securitycontext
Which issue(s) this PR fixes
Fixes #2819
-Bug fix: If a securityContext is set the process is not able to create directory
To solve it I create an emptyDir volume
The securitycontext is also add for job and webhook
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update