-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating golang version to fix a few vulnerabilities #275
Conversation
Welcome @soorena776! |
Hi @soorena776. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
I realized we have 1.16 in go.mod, we may need to keep consistent: https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/master/go.mod#L3 |
+1 |
Would also be good to update https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/master/konnectivity-client/go.mod#L3 to at least go1.15 (https://github.com/kubernetes/kubernetes/blob/release-1.20/go.mod#L9) |
24dd5d6
to
d94239f
Compare
/retest-required |
d94239f
to
2b5a80b
Compare
@@ -20,4 +20,38 @@ require ( | |||
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.0 | |||
) | |||
|
|||
require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like 1.17 adds all the hidden dependencies to go.mod, for better visibility.
https://golang.org/doc/go1.17#go-command
2b5a80b
to
ba03188
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, soorena776 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This makes tests consistent with kubernetes-sigs/apiserver-network-proxy#275
This fix addresses the following vulnerabilities: