chore: fix field comments on ClientSet #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not following the go conventions here means the wrong comments appear in IDEs.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
cheftako
reviewed
Jan 29, 2025
| // agentID is "our ID" - the ID of this agent. | ||
| agentID string | ||
|
|
||
| // Address is the proxy server address. Assuming HA proxy server |
There was a problem hiding this comment.
TODO to improve this. Its the address we use to contact the ANP Server. Normally this would be a LB address in front of the ANP Servers.
cheftako
reviewed
Jan 29, 2025
| // Address is the proxy server address. Assuming HA proxy server | ||
| address string | ||
|
|
||
| // leaseCounter counts number of proxy server leases |
There was a problem hiding this comment.
TODO: This only used if the relevant feature is enabled.
cheftako
reviewed
Jan 29, 2025
| // channel to signal shutting down the client set. Primarily for test. | ||
| stopCh <-chan struct{} | ||
|
|
||
| agentIdentifiers string // The identifiers of the agent, which will be used | ||
| // agentIdentifiers is the identifiers of the agent, which will be used |
There was a problem hiding this comment.
I believe this is a comma delineated list.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not following the go conventions here means the wrong comments
appear in IDEs.