Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'addOwnerRef' flag to the spec. #87

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Add 'addOwnerRef' flag to the spec. #87

merged 4 commits into from
Feb 20, 2019

Conversation

barney-s
Copy link
Contributor

@barney-s barney-s commented Feb 2, 2019 •
edited
Loading

When addOwnerRef is true, inject appcrd as one of the owners for the matching objects
The .controller field of the owner ref is set to false.

fixes #86

@barney-s
Add 'adopt' flag to the spec.
d0fb5b7 
When adopt is true, inject appcrd as one of the owners for the matching objects
The .controller field of the owner ref is set to false
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 2, 2019
@barney-s
Copy link
Contributor Author

barney-s commented Feb 2, 2019

@mortent @huyhg @ant31 @janetkuo

Please review

@kow3ns kow3ns self-assigned this Feb 2, 2019
@ant31
Copy link
Contributor

ant31 commented Feb 5, 2019

other suggestion than 'adopt' ?

  • manageOwnerRef
  • addOwnerRef
    ....

@barney-s
Copy link
Contributor Author

barney-s commented Feb 5, 2019

  • manageOwnerRef
  • addOwnerRef

addOwnerRef seems explicit. I like that.

huyhg
huyhg reviewed Feb 6, 2019
View reviewed changes
Copy link
Contributor

@huyhg huyhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR's description.

pkg/genericreconciler/genericreconciler.go Show resolved Hide resolved
@huyhg
Copy link
Contributor

huyhg commented Feb 6, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@huyhg: changing LGTM is restricted to assignees, and only kubernetes-sigs/application repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ant31
Copy link
Contributor

ant31 commented Feb 7, 2019

does it close # 7?
cc @kow3ns

@janetkuo
Copy link
Member

janetkuo commented Feb 7, 2019

FYI I filed a PR to document the owner ref restriction: kubernetes/website#12543
@barney-s @huyhg @mortent

@barney-s barney-s changed the title Add 'adopt' flag to the spec. Add 'addOwnerRef' flag to the spec. Feb 11, 2019
@barney-s
Copy link
Contributor Author

@janetkuo added comments describing the ownerref matching.
please lgtm.

Can some one please merge this.

@ant31
Copy link
Contributor

ant31 commented Feb 14, 2019

/lgtm

need approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2019
@cmoulliard
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

@cmoulliard: changing LGTM is restricted to assignees, and only kubernetes-sigs/application repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kow3ns
Copy link
Contributor

kow3ns commented Feb 20, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, kow3ns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 37ccdcb into kubernetes-sigs:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyhg huyhg huyhg left review comments

@janetkuo janetkuo janetkuo left review comments

@ant31 ant31 ant31 left review comments

@mortent mortent mortent left review comments

@michelleN michelleN Awaiting requested review from michelleN

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@ant31 ant31

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Flag to adopt resources
8 participants
@barney-s @ant31 @huyhg @k8s-ci-robot @janetkuo @cmoulliard @kow3ns @mortent