Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume resizing support for windows #1207

Merged

Conversation

torredil
Copy link
Member

Signed-off-by: Eddie Torres torredil@amazon.com

Is this a bug fix or adding new feature?

  • New feature

What is this PR about? / Why do we need it?

  • When attempting to resize a volume on Windows by editing the PVC, you will encounter the error: "Resize is not supported for this build".
  • In the current implementation, the NodeExpandVolume function in the node service is not platform agnostic because it uses the mount-utils package to resize the file system. The mount-utils package does not implement the Resize function for windows environments.
  • Added support for resizing on Windows using the CSI Proxy, which allows the driver to issue privileged operations through a gRPC interface exposed over named pipes.
  • Created custom resizefs package maintained for the windows implementation only which will be used to return an instance of NewResizeFs and implement the resize interface.
  • Invoked in node.go by calling mounter.NewResizeFs() to create an instance of NewResizeFs based on the environment context, and finally, calling Resize on that instance of NewResizeFs

What testing is done?

  • make test succeeds.
  1. Build and upload container images to a registry.
  2. Change the image in the helm chart.
  3. Test resizing functionality using the new helm chart.

Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @torredil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 12, 2022
@AndyXiangLi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2022
@gtxu
Copy link
Contributor

gtxu commented Apr 18, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtxu, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit a2d1d0f into kubernetes-sigs:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants