-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mountOptions support #130
Add mountOptions support #130
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 199
💛 - Coveralls |
@bertinatto Did you get a chance to test the change? Could you give some details on the testing? Other than this, LGTM. |
@leakingtapan, I created a volume using this storage class:
And I verified that the volume was mounted with the option |
/lgtm |
We should add unit test for node service to improve the code coverage. Ref #142 Merge the PR to not block the feature |
Fixes #102.
/kind feature
/assign @leakingtapan