Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add govulncheck and dependency-review to CI workflow #1786

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add govulncheck and dependency-review to CI workflow #1786

merged 1 commit into from
Oct 25, 2023

Conversation

torredil
Copy link
Member

What is this PR about? / Why do we need it?

This PR adds govulncheck and dependency-review-action CI checks for pull request events.

What testing is done?

CI

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2023
AndrewSirenko
AndrewSirenko reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@AndrewSirenko
Copy link
Contributor

AndrewSirenko commented Oct 16, 2023 •
edited
Loading

We should wait to merge this until we fix the vulnerabilities govulncheck is helping us find?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2023
@torredil
Add govulncheck and dependency-review to CI workflow
32e18d3 
Signed-off-by: Eddie Torres <torredil@amazon.com>
@torredil
Copy link
Member Author

@AndrewSirenko Green now. The driver's container image is based on the Go version specified in the Dockerfile, which defaults to using the latest patch version of the minor version used, govulncheck scans against that version.

The http related vulnerability in Go's standard lib is fixed in the latest patch release for 1.21. Bumped up the Go version in the Dockerfile -- new builds will reference 1.21.3 which fixes the CVE.

@AndrewSirenko
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2023
@AndrewSirenko
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 9f3e154 into kubernetes-sigs:master Oct 25, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSirenko AndrewSirenko AndrewSirenko left review comments

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

Assignees

@ConnorJC3 ConnorJC3

@AndrewSirenko AndrewSirenko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@torredil @AndrewSirenko @k8s-ci-robot @ConnorJC3