-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permissions to all GitHub actions #2143
Add permissions to all GitHub actions #2143
Conversation
b97a348
to
08a1cee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Could we follow the best-practice of commenting why you need each permission as seen in the kubernetes-sigs/karpenter project?
Signed-off-by: Connor Catlett <conncatl@amazon.com>
08a1cee
to
11cf5b2
Compare
Added comments to all the permissions that aren't |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@ElijahQuinones: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is this a bug fix or adding new feature?
"Bug fix"
What is this PR about? / Why do we need it?
The
kubernetes-sigs
GitHub org was moved to a GitHub enterprise account, changing the default permissions for actions. Explicitly define the permissions we need in each action so they continue to run successfully.What testing is done?
CI