Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VolumeAttributesClass example to beta #2150

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?
Update

What is this PR about? / Why do we need it?

The current ModifyVolume example will not work with aws-ebs-csi-driver version >= v1.35.0 due to the VolumeAttributesClass object upgrading to v1beta1 in Kubernetes v1.31 and external sidecars.

Also decreased volume size and iops to be more frugal.

Am open to updating modify-volume.md further to remove steps that are no longer relevant for aws-ebs-csi-driver >= 1.35.0 (i.e. adding feature gate on sidecars manually instead of relying on our helm chart)

What testing is done?
Going through example manually

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Code Coverage Diff

This PR does not change the code coverage

docs/modify-volume.md Outdated Show resolved Hide resolved
examples/kubernetes/modify-volume/README.md Outdated Show resolved Hide resolved
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 instances of storage.k8s.io/v1alpha1 in https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/tagging.md - would now be a good time to update these as well? besides this, PR lgtm.

Thank you for continuing to maintain the documentation in this repo up to date.

… feature

Signed-off-by: Connor Catlett <conncatl@amazon.com>
@AndrewSirenko
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
@ElijahQuinones
Copy link
Member

/lgtm
Thanks for updating the docs Drew

@k8s-ci-robot
Copy link
Contributor

@ElijahQuinones: changing LGTM is restricted to collaborators

In response to this:

/lgtm
Thanks for updating the docs Drew

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2efda4c into kubernetes-sigs:master Sep 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants