-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VolumeAttributesClass example to beta #2150
Update VolumeAttributesClass example to beta #2150
Conversation
Code Coverage DiffThis PR does not change the code coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 instances of storage.k8s.io/v1alpha1
in https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/tagging.md - would now be a good time to update these as well? besides this, PR lgtm.
Thank you for continuing to maintain the documentation in this repo up to date.
ce9a4a5
to
0bd838e
Compare
… feature Signed-off-by: Connor Catlett <conncatl@amazon.com>
0bd838e
to
ea40de2
Compare
ea40de2
to
a214215
Compare
/retest |
/lgtm |
@ElijahQuinones: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Update
What is this PR about? / Why do we need it?
The current ModifyVolume example will not work with aws-ebs-csi-driver version >= v1.35.0 due to the VolumeAttributesClass object upgrading to v1beta1 in Kubernetes v1.31 and external sidecars.
Also decreased volume size and iops to be more frugal.
Am open to updating
modify-volume.md
further to remove steps that are no longer relevant for aws-ebs-csi-driver >= 1.35.0 (i.e. adding feature gate on sidecars manually instead of relying on our helm chart)What testing is done?
Going through example manually