Improve observability of InsufficientVolumeCapacity errors
#2155
Conversation
Signed-off-by: torredil <torredil@amazon.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
Code Coverage DiffThis PR does not change the code coverage |
|
/retest |
| AvailabilityZone: expZone, | ||
| }, | ||
| expCreateVolumeInput: &ec2.CreateVolumeInput{ | ||
| Iops: aws.Int32(2000), |
There was a problem hiding this comment.
Is there a reason we need this iops input?
k8s-ci-robot
added
the
lgtm
|
@torredil: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -176,6 +176,9 @@ var ( | |||
|
|
|||
| // ErrInvalidRequest is returned if parameters were rejected by driver | |||
| ErrInvalidRequest = errors.New("invalid request") | |||
|
|
|||
| // ErrInsufficientVolumeCapacity is returned when there's not enough capacity to fulfill the volume provision request. | |||
| ErrInsufficientVolumeCapacity = errors.New("There is not enough capacity to fulfill your EBS volume provision request. You can try to provision a different volume type, EBS volume in a different availability zone, or you can wait for additional capacity to become available.") | |||
There was a problem hiding this comment.
Why are we adding our own error message here? Is the error message from EBS not sufficient?
(What even is the error message the EBS API returns here? Neither the PR nor the linked issue contains it)
k8s-ci-robot
removed
the
lgtm
|
/close |
|
@torredil: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is this a bug fix or adding new feature?
Neither, kaizen.
closes #2154
What is this PR about? / Why do we need it?
This PR enhances the driver's ability to communicate
InsufficientVolumeCapacityerrors from the AWS API by providing a more informative error message to users.What testing is done?
See https://docs.aws.amazon.com/AWSEC2/latest/APIReference/errors-overview.html for more information related to error codes.