Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloud provider interface to take in context #45

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Update cloud provider interface to take in context #45

merged 1 commit into from
Oct 8, 2018

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Oct 5, 2018 •
edited
Loading

Only with the context object populated through the call stack, the operation could be cancelled properly. This PR fixes this issue.

Fixes: #37

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot requested a review from d-nishi October 5, 2018 17:36
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2018
@coveralls
Copy link

coveralls commented Oct 5, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 21

  • 21 of 35 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.15%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloud/cloud.go 18 20 90.0%
pkg/driver/controller.go 3 8 37.5%
pkg/cloud/fakes.go 0 7 0.0%
Totals Coverage Status
Change from base Build 18: 0.0%
Covered Lines: 455
Relevant Lines: 965
💛 - Coveralls

Update cloud provider interface to take in context
af3bcdd 
With the context object populated through the call stack, the operation
could be cancelled properly
@bertinatto
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 799bb24 into kubernetes-sigs:master Oct 8, 2018
@leakingtapan leakingtapan deleted the add-context branch October 8, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update cloud API to consume context
4 participants
@leakingtapan @k8s-ci-robot @coveralls @bertinatto