Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CSIMigrationAWSComplete for migration tests #593

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Oct 16, 2020

Is this a bug fix or adding new feature? fix

What is this PR about? / Why do we need it? IDK if checking metrics' plugin_name #560 (comment) is a valid way of testing whether migration is working or not, better to set CSIMigrationAWSComplete to turn off the in-tree plugin entirely.

What testing is done? N/A, the migration suite is currently failing

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1271

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.253%

Totals Coverage Status
Change from base Build 1269: 0.0%
Covered Lines: 1595
Relevant Lines: 1963

💛 - Coveralls

@wongma7
Copy link
Contributor Author

wongma7 commented Oct 16, 2020

Since translation happens before the volume is added to desired state of world and so before any operations are done on it, https://github.com/kubernetes/kubernetes/blob/e23d83eead3b5ae57731afb0209f4a2aaa4009dd/pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go#L583 I would expect that if migration is enabled the metrics should have plugin_name ebs.csi.aws.com NOT kubernetes.io/aws-ebs ...

@wongma7
Copy link
Contributor Author

wongma7 commented Oct 16, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@wongma7
Copy link
Contributor Author

wongma7 commented Oct 16, 2020

io2 flake

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [leakingtapan,wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wongma7
Copy link
Contributor Author

wongma7 commented Oct 19, 2020

io2 again, i am checking if the account has some kind of volume type specific limit ???

/retest

@wongma7
Copy link
Contributor Author

wongma7 commented Oct 23, 2020

/retest

@wongma7
Copy link
Contributor Author

wongma7 commented Oct 26, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@k8s-ci-robot k8s-ci-robot merged commit 27dbc74 into kubernetes-sigs:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants