-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CSIMigrationAWSComplete for migration tests #593
Set CSIMigrationAWSComplete for migration tests #593
Conversation
Pull Request Test Coverage Report for Build 1271
💛 - Coveralls |
Since translation happens before the volume is added to desired state of world and so before any operations are done on it, https://github.com/kubernetes/kubernetes/blob/e23d83eead3b5ae57731afb0209f4a2aaa4009dd/pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go#L583 I would expect that if migration is enabled the metrics should have plugin_name ebs.csi.aws.com NOT kubernetes.io/aws-ebs ... |
/test pull-aws-ebs-csi-driver-e2e-single-az |
io2 flake |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
io2 again, i am checking if the account has some kind of volume type specific limit ??? /retest |
/retest |
/test pull-aws-ebs-csi-driver-e2e-single-az |
Is this a bug fix or adding new feature? fix
What is this PR about? / Why do we need it? IDK if checking metrics' plugin_name #560 (comment) is a valid way of testing whether migration is working or not, better to set CSIMigrationAWSComplete to turn off the in-tree plugin entirely.
What testing is done? N/A, the migration suite is currently failing