-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds patch for ebs-csi-controller-sa to volumeattachments/status #690
Conversation
Welcome @cuppett! |
Hi @cuppett. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1455
💛 - Coveralls |
Allows patching volumeattachments/status by the csi-attacher sidecar.
We'd like to update the sidecars as soon as possible, but haven't gotten around to it yet. Appreciate the help! /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk, cuppett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #689
Allows patching volumeattachments/status.
Is this a bug fix or adding new feature?
bug
What is this PR about? / Why do we need it?
It appears the external attacher communicates by updating the status of volumeattachments, but the existing clusterrole doesn't have that ability.
What testing is done?
Have validated is resolves #689 within an EKS cluster.