Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message when IOPSPerGB is missing in io1 volumes #767

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix error message when IOPSPerGB is missing in io1 volumes #767

merged 1 commit into from
Feb 25, 2021

Conversation

jsafrane
Copy link
Contributor

Explicitly return specific message in this case, otherwise the cloud returns generic The parameter iops must be specified for io1 volumes, which mentions iops, but the parameter that the user needs to set is IOPSPerGB.

Fixes: #766

@jsafrane
Fix error message when IOPSPerGB is missing in io1 volumes
ea61ade 
Explicitly return speicific message in this case, otherwise the cloud
returns generic "The parameter iops must be specified for io1 volumes",
which mentions "iops", but the parameter that the user needs to set is
"IOPSPerGB".
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from wongma7 February 24, 2021 14:34
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1631

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 81.69%
Totals Coverage Status
Change from base Build 1626: 0.03%
Covered Lines: 1740
Relevant Lines: 2130
💛 - Coveralls

@wongma7
Copy link
Contributor

wongma7 commented Feb 25, 2021

indeed 'parameters' is ambiguous. many THANKS

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5b31c93 into kubernetes-sigs:master Feb 25, 2021
@ayberk
Copy link
Contributor

ayberk commented Feb 25, 2021

Don't we need this for io2 as well?

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 1, 2021

I did not test it, however, I think that the error message The parameter iops must be specified for io2 volumes will be correct.

@surian surian mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error message when creating "io1" volumes
5 participants
@jsafrane @k8s-ci-robot @coveralls @wongma7 @ayberk