Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump back CSIDriver to beta1 version #888

Closed
wants to merge 1 commit into from
Closed

Bump back CSIDriver to beta1 version #888

wants to merge 1 commit into from

Conversation

arcivanov
Copy link
Contributor

v1 went GA in 1.18. This chart is >= 1.17.
In 1.17 CSIDriver is only available in v1beta1

fixes #887

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

What testing is done?

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @arcivanov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arcivanov
To complete the pull request process, please assign bertinatto after the PR has been reviewed.
You can assign the PR to them by writing /assign @bertinatto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from d-nishi and gnufied May 16, 2021 06:23
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2021
@coveralls
Copy link

coveralls commented May 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1962

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.188%
Totals Coverage Status
Change from base Build 1955: 0.0%
Covered Lines: 1990
Relevant Lines: 2513
💛 - Coveralls

@arcivanov
Bump back CSIDriver to beta1 version
0f4a72c 
v1 went GA in 1.18. This chart is >= 1.17.
In 1.17 CSIDriver is only available in v1beta1

fixes 887
@arcivanov arcivanov force-pushed the fix_csi_driver_version branch from 46ab3a2 to 0f4a72c Compare May 16, 2021 06:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 16, 2021
@arcivanov
Copy link
Contributor Author

@AndyXiangLi

@AndyXiangLi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2021
AndyXiangLi
AndyXiangLi reviewed May 18, 2021
View reviewed changes
charts/aws-ebs-csi-driver/templates/csidriver.yaml
@@ -1,4 +1,4 @@
apiVersion: storage.k8s.io/v1
apiVersion: storage.k8s.io/v1beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As v1beta1 will be deprecated soon(likely 3 months), can you update the apiVersion based on kubeVersion? something like
{{ ternary "storage.k8s.io/v1" "storage.k8s.io/v1beta1" (semverCompare ">=1.19.0-0" .Capabilities.KubeVersion.Version) }}
Also, since this is helm chart change, can you also bump the chart version to 1.0.2?

@AndyXiangLi
Copy link
Contributor

Hi @arcivanov, we need to patch v1.0 release as well so I will merge the fix on my own and also cherry pick it to v1.0 branch, thanks for your work!

@AndyXiangLi
Copy link
Contributor

We have a PR to cleanup helm in #856 which include this fix, I will close this PR

@arcivanov arcivanov deleted the fix_csi_driver_version branch May 25, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyXiangLi AndyXiangLi AndyXiangLi left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

@gnufied gnufied Awaiting requested review from gnufied

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSIDriver v1 is not available in 1.17
4 participants
@arcivanov @k8s-ci-robot @coveralls @AndyXiangLi