Skip to content

Commit

Permalink
Install efs-utils from github by default. Provide an option to instal…
Browse files Browse the repository at this point in the history
…l efs-utils from Amazon Linux 2 yum repo
  • Loading branch information
Karthik Basavaraj committed May 12, 2021
1 parent 61e2d92 commit 9198a2e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
15 changes: 13 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,25 @@ RUN echo "I am running on $(uname -s)/$(uname -m)"

ADD . .

# Default client source is `k8s` which can be overriden with –build-arg when building the Docker image
# Default client source is `k8s` which can be overriden with –-build-arg when building the Docker image
ARG client_source=k8s
ENV EFS_CLIENT_SOURCE=$client_source

RUN GOOS=${TARGETOS} GOARCH=${TARGETARCH} make aws-efs-csi-driver

FROM amazonlinux:2.0.20210219.0
RUN yum install amazon-efs-utils-1.30.1-1.amzn2.noarch -y
# Install efs-utils from github by default. It can be overriden to `yum` with --build-arg when building the Docker image.
# If value of `EFSUTILSSOURCE` build arg is overriden with `yum`, docker will install efs-utils from Amazon Linux 2's yum repo.
ARG EFSUTILSSOURCE=github
# Install efs-utils from github
RUN if [ "$EFSUTILSSOURCE" = "yum" ]; \
then echo "Installing efs-utils from Amazon Linux 2 yum repo" && \
yum -y install amazon-efs-utils-1.30.1-1.amzn2.noarch; \
else echo "Installing efs-utils from github" && \
yum -y install git rpm-build make && \
git clone https://github.com/aws/efs-utils && \
cd efs-utils && make rpm && yum -y install build/amazon-efs-utils*rpm; \
fi

# At image build time, static files installed by efs-utils in the config directory, i.e. CAs file, need
# to be saved in another place so that the other stateful files created at runtime, i.e. private key for
Expand Down
2 changes: 1 addition & 1 deletion pkg/driver/efs_watch_dog.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ func (w *execWatchdog) runLoop(stopCh <-chan struct{}) {
for {
select {
case <-stopCh:
//klog.Info("stopping...")
klog.Info("stopping...")
break
default:
err := w.exec()
Expand Down

0 comments on commit 9198a2e

Please sign in to comment.