Updated the README with information on mountOptions that can be provided while mounting. #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
mskanth972
force-pushed
the
optionupdate
branch
2 times, most recently
from
9fa5bbe
to
1aaad15
Compare
mskanth972
changed the title
RyanStan
reviewed
May 18, 2023
docs/README.md
Outdated
| @@ -47,6 +47,15 @@ The following CSI interfaces are implemented: | |||
| * The uid/gid configured on the access point is either the uid/gid specified in the storage class, a value in the gidRangeStart-gidRangeEnd (used as both uid/gid) specified in the storage class, or is a value selected by the driver is no uid/gid or gidRange is specified. | |||
| * We suggest using [static provisioning](https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/examples/kubernetes/static_provisioning/README.md) if you do not wish to use user identity enforcement. | |||
|
|
|||
| **Note** | |||
|
|
|||
| If you want to pass any other mountOptions to EFS CSI driver while mounting, they can be passed in pv and storage class for static and dynamic provisioning respectively. | |||
There was a problem hiding this comment.
I would capitalize the Kubernetes resources ->
...they can be passed in through the Persistent Volume or the Storage Class objects, depending on whether static or dynamic provisioning is used.
docs/README.md
Outdated
|
|
||
| **lookupcache**: Specifies how the kernel manages its cache of directory entries for a given mount point. Mode can be one of all, none, pos, or positive. Each mode has different functions and for more information you can refer to this [link](https://linux.die.net/man/5/nfs). | ||
|
|
||
| **iam**: The IAM option allows you to control the AWS Identity and Access Management Permissions for the EFS CSI driver and the associated EFS file system. |
There was a problem hiding this comment.
I would reword the iam option. Maybe something like
"Use the CSI Node Pod's IAM identity to authenticate with EFS".
…ded while mounting.
RyanStan
approved these changes
May 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, RyanStan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-aws-efs-csi-driver-unit |
1 similar comment
|
/test pull-aws-efs-csi-driver-unit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
Updated the README with information on mountOptions that can be provided while mounting.
What testing is done?