Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when unpublishing already unmounted file system #106

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Fix bug when unpublishing already unmounted file system #106

merged 1 commit into from
Nov 28, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
/kind bug

What is this PR about? / Why do we need it?
Fix bug when unpublishing already unmounted file system. This happens when lingering EFS mount is found on the node such as:

  volumesInUse:
  - kubernetes.io/csi/efs.csi.aws.com^fs-26e5fe8d
  - kubernetes.io/csi/efs.csi.aws.com^fs-e8a95a42

This will cause kubelet to keep unmounting the volume with no success since the volume is already unmounted.

The lingering volume in node object could be caused when the EFS filesystem is unmounted out of band or bugs.

What testing is done?

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2019
@leakingtapan
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2019
@leakingtapan
Copy link
Contributor Author

/cc @wongma7

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2019
@leakingtapan leakingtapan merged commit 206d218 into kubernetes-sigs:master Nov 28, 2019
@leakingtapan leakingtapan deleted the unpublish branch November 28, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@justinsb justinsb Awaiting requested review from justinsb

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leakingtapan @k8s-ci-robot