Add CSI_NODE_NAME to node Daemonset #1124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added CSI_NODE_NAME as an environment variable to the Helm Chart's node Daemonset, but we forget to add it to our kustomize deploy files as well. This is required for users who have IMDS disabled on their cluster, and who install the driver using kustomize.
This fixes #1111.
For more background,
This recent commit removed
hostNetwork = true
from the node daemonset. This means that the Node Daemonset Pods cannot use IMDS for getting the region.A while ago, this commit was merged which allows us to pull EC2 info from Kubernetes instead of IMDS if IMDS is enabled. However, it requires the
CSI_NODE_NAME
env variable to be set. The author of this commit only added it to the Controller Deployment, but our Node Daemonset needs it as well. Thus, that's why the commit above, wherehostNetwork = true
was removed, also introduced thisCSI_NODE_NAME
to our Helm Chart. However, it wasn't added to the Node daemonset spec that our Kustomize files use.Is this a bug fix or adding new feature?
Bug fix
What testing is done?
I applied a static provisioning example while enforcing IMDSv2 was used (which disabled IMDS).